[FEAT]: Add team command group#727
Conversation
| var err error | ||
|
|
||
| spinErr := bkIO.SpinWhile(f, "Loading teams information", func() { | ||
| teams, _, err = f.RestAPIClient.Teams.List(ctx, f.Config.OrganizationSlug(), nil) |
There was a problem hiding this comment.
Any concerns about not paginating here? I'm not sure how many teams we return per page, but I'm guessing sooner or later we will come across someone who has hundreds of them.
| Description: current.Description, | ||
| Privacy: current.Privacy, | ||
| IsDefaultTeam: current.Default, | ||
| MembersCanCreatePipelines: false, |
There was a problem hiding this comment.
Claude flagged the fact that every time someone updates a team, it's going to set members_can_create_pipelines: false even if the current setting for that team is true. "Balderdash," said I. "Prove it!" So we looked at go_buildkite, where it turns out that the Team struct doesn't include all the fields that the API returns, including MembersCanCreatePipelines. And then looking upstream at the API in Team::Updater and how it would handle this, it looks like it would in fact apply the false flag and change the setting unexpectedly. We'd need to fix this in go_buildkite and then here do MembersCanCreatePipelines: current.MembersCanCreatePipelines,
If this makes sense to you, I can throw the PR at go_buildkite and then add a commit to this.
There was a problem hiding this comment.
I think false is a sensible default? It's definitely safer than true and would still allow for creation of the team but with safeguards in place.
There was a problem hiding this comment.
Discussed in Slack - we still need to fix go_buildkite to avoid us forcibly changing this setting when we update teams. That'll be a separate task.
341f59d to
d4f894d
Compare
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
The latest merge from main left the branch unbuildable. I left three blockers for the parse, module, and callback-signature failures reported by CI, plus one non-blocking pagination edge case.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 8503, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
There was a problem hiding this comment.
The three build/compile blockers from the last pass are fixed. The pagination edge case is still open, and I left three non-blocking CLI edge cases inline.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 8563, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
Previous concerns have been addressed.
There was a problem hiding this comment.
All prior buildsworth concerns are addressed in the current revision, and I found no new issues. This adds destructive and permission-changing team operations, so this remains comment-only.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 8582, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
2 participants
Description
Adds support for group of
teamcommands, as available in go-buildkiteChanges
team {create,delete,list,update,view}main.goto supportTesting
go test ./...)go fmt ./...)